in making a solution of an unknown solid substance to test it for the presence of ions, would it matter if you used pure water or tap water to make the solution

Hmmm. I have never in my life encountered Pure water.

But I wouldn't use tap water if you are testing for an unknown...lord knows what is in tap water.