Bad breath and yellow teeth are correctly mentioned as short-term effects of smoking. However, feeling tired is primarily associated with the long-term effects of smoking, rather than short-term effects. Cancer, on the other hand, is not an immediate short-term effect of smoking, but rather a potential long-term consequence.