Is this sentence grammatically correct? If not how can i fix it?
Those who do have what they want crave for more; they want love and affection.
It's grammatically correct -- but I'd omit "do."
However, it doesn't make a lot of sense. If they have what they want, how can they crave more?
Do you mean?
Those who have all the money they want often crave love and affection.
I meant kids that get everything they want often want more. Like they begin to believe that being spoiled with items is not everything.
Are you saying they want more "toys?" Or are they dissatisfied because they also need love and affection?
dissatisfied.
In this sentence should it be will or would? Why will I want to have everything except for love?
I think "would" is better there.
Yes, the sentence is grammatically correct. However, if you want to improve the sentence, you can make a small change to enhance its clarity and flow. Here's a revised version:
"Those who already have what they want often crave for more, particularly in terms of love and affection."