If I begin with 2.5g of Mg and excess HCL. How many liters of H2 gas will I produce at 25C and 1 atm?

2HCL + Mg ----> MgCl2 + h2
?? using pv=nRT

mols Mg = grams/molar mass.

Convert mols Mg to mols H2 produced. Use the coefficients in the balanced equation.
Then use PV = nRT to solve for volume in liters at the conditions listed.