was the british empire a good or bad thing?

That is entirely subjective. Why don't you list the good points, and the not so good points, and think on them.

It may end up for you asking this: Is civilization a good or bad thing?

Again, that is subjective.