If so many intellectuals think that Freud was wrong about many components of his theory of personality, why have his ideas persisted over time?

His ideas were revolutionary. They set the stage for further development of personality and behaviour. He was the first to recognize that relationships early in life caused fundamental personality stability or disorder.

We recognize Freud for what he was: a pioneer. He did not make the final map, it is still being made.